Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring gRPC Support #1963

Closed
waprin opened this issue Jul 6, 2016 · 7 comments
Closed

Monitoring gRPC Support #1963

waprin opened this issue Jul 6, 2016 · 7 comments
Assignees
Labels
api: monitoring Issues related to the Cloud Monitoring API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@waprin
Copy link
Contributor

waprin commented Jul 6, 2016

I'm trying to better understand the roadmap of gRPC clients.

Monitoring team really wants gRPC support for their API. However rather than compiling protos and distributing separate Python packages (like Pub/Sub did) I am recommending we hold off until we get gRPC support in here.

However I'm unclear

  • What works needs to be done to get the existing client working on gRPC
  • Whether that work is already planned on a roadmap
  • Any other gotchas/general status with gRPC and this library

/cc @rimey

@sharbison3
Copy link

I have not yet heard that the monitoring team "really wants gRPC support." Did I miss a memo?

@tseaver
Copy link
Contributor

tseaver commented Jul 6, 2016

@waprin we'd really prefer not to be wedging any more generated code into the project: the process of generating / maintaining it is a serious burden. Getting the existing proto-generated stuff distributed as separate libraries is already a goal (see #1384).

The https://github.com/googleapis/ team has been working on automating builds of such libraries: maybe they could help?

@waprin
Copy link
Contributor Author

waprin commented Jul 6, 2016

@tseaver ok I have misunderstood the goals of what's going on. My understanding was that the Google APIs team was generating libraries for the express purpose of being included in this library.

@bjwatson
Copy link

@omaray What do you think?

@waprin
Copy link
Contributor Author

waprin commented Jul 18, 2016

@bjwatson I think there was a small miscommunication here, because I wasn't asking to merge in generated code but how we can rebase the handwritten to duplex between HTTP or VTK once it is generated like is currently done for Logging/Pubsub. Omar is out this week and wasn't sure if/when it would get on official roadmap, he wanted to hear from @jgeewax.

@bjwatson
Copy link

@waprin Sorry, I was chiming in on an issue I only partially understood. :/

I'm happy to hear that Omar is already in the loop, and it sounds like this is definitely a question of the roadmap for gcloud.

@dhermes dhermes added the api: monitoring Issues related to the Cloud Monitoring API. label Jul 20, 2016
@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 19, 2017
@lukesneeringer
Copy link
Contributor

Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.

As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.

My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

6 participants