Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.cloud.error_reporting AttributeError: 'Client' object has no attribute '_project' #3233

Closed
DizzeePascall opened this issue Mar 29, 2017 · 11 comments
Assignees
Labels
api: clouderrorreporting Issues related to the Error Reporting API.

Comments

@DizzeePascall
Copy link
Contributor

When running the examples from the documentation, I get the following error: AttributeError: 'Client' object has no attribute '_project'

Disabling GRPC via the GOOGLE_CLOUD_DISABLE_GRPC environment variable fixes this.

I'm running on an Ubuntu 14.04 compute instance with python 3.5.3 and version 023.2 of the google-cloud-error-reporting project

@DizzeePascall
Copy link
Contributor Author

DizzeePascall commented Mar 29, 2017

The problem seems to exist because PRs #3168 and #3159 have interefered with each other

@dhermes
Copy link
Contributor

dhermes commented Mar 29, 2017

@DizzeePascall We just pushed 0.23.2 to fix this issue. Can you try updating?

Happy to re-open if this is still an issue for you.

@DizzeePascall
Copy link
Contributor Author

@dhermes I'm running 0.23.2. As I mentioned, two PRs were filed to address a similar problem in 0.23.1, but ironically they've cancelled each other out. This shouldn't be closed yet

@dhermes
Copy link
Contributor

dhermes commented Mar 29, 2017

Thanks for the heads up. Can you post the snippet you used that failed so we can confirm as well? (You like linked to one PR and one issue, maybe you meant to link to two PRs?)

@dhermes dhermes reopened this Mar 29, 2017
@DizzeePascall
Copy link
Contributor Author

@dhermes Good point, I've updated my comment above

@dhermes
Copy link
Contributor

dhermes commented Mar 29, 2017

Confirming the issue:

$ git grep -n '\._project' -- error_reporting/
error_reporting/google/cloud/error_reporting/_gax.py:44:    return _ErrorReportingGaxApi(gax_client, client._project)
error_reporting/google/cloud/error_reporting/_gax.py:60:        self._project = project
error_reporting/google/cloud/error_reporting/_gax.py:73:        project_name = self._gax_api.project_path(self._project)
error_reporting/tests/unit/test__gax.py:55:        self.assertIs(report_error_client._project, client._project)
error_reporting/tests/unit/test__gax.py:71:        self.assertEqual(gax_client_wrapper._project, self.PROJECT)
$ # WHERE/WHEN
$ git log -1 --pretty=%H
e63ddc384e4a54a6a085595d779a399ed449c26c

@asilversempirical
Copy link

Any ETA on a fix for this? My team's error reporting is broken on this. Should we just temporarily pin to .23.0?

@dhermes
Copy link
Contributor

dhermes commented Mar 30, 2017

@asilversempirical Hopefully 0.24.0 (not 0.23.2) will come out this afternoon via #3245

@asilversempirical
Copy link

Excellent, thank you for being on top of this :)

@lukesneeringer
Copy link
Contributor

We missed yesterday afternoon, but it is coming out this morning.

@lukesneeringer
Copy link
Contributor

This issue should be fixed in 0.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the Error Reporting API.
Projects
None yet
Development

No branches or pull requests

4 participants