Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

continue exposing some retry imports for backwards compatibility #575

Closed
vchudnov-g opened this issue Dec 19, 2023 · 2 comments · Fixed by #577
Closed

continue exposing some retry imports for backwards compatibility #575

vchudnov-g opened this issue Dec 19, 2023 · 2 comments · Fixed by #577
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vchudnov-g
Copy link
Contributor

For backwards compatibility, we need to expose some imports that were removed in #495. These include at least google.api_core.datetime_helpers, but other diffs in the imports that we may want to restore are api_core.exceptions, datetime, and logging
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 19, 2023
@vchudnov-g
Copy link
Contributor Author

Marking this as a P1 bug since it does block shipping the next release, which is intended to be only a minor version update.

@vchudnov-g vchudnov-g mentioned this issue Dec 19, 2023
Open
@vchudnov-g vchudnov-g mentioned this issue Jan 29, 2024
Merged
@vchudnov-g
Copy link
Contributor Author

After a separate discussion, we agreed to not expose standard imports transitively if we don't need them in our implementation.

I think it would be good if the Python community spelled this out somewhere, but that's a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: for backwards compatibility, expose legacy retry imports googleapis/python-api-core
1 participant
@vchudnov-g