Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new client options #116

Closed
busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #132
Closed

Implement new client options #116

busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #132
Assignees
@HemangChothani
Labels
api: spanner Issues related to the googleapis/python-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@busunkim96
Copy link
Contributor

Add support for the three new client_options quota_project_id, scopes, and credentials_file. These options are implemented on the mirogenerator, so the completion of the migration may automatically fulfill this.

https://googleapis.dev/python/google-api-core/latest/client_options.html
@busunkim96 busunkim96 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 22, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 22, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

I believe this work is blocked on merge / release of googleapis/python-cloud-core#15

@tseaver tseaver added status: blocked Resolving the issue is dependent on other work. and removed status: blocked Resolving the issue is dependent on other work. labels Aug 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

PR needs to pin google-cloud-core >= 1.4.0, < 2.0dev.

@HemangChothani HemangChothani self-assigned this Aug 10, 2020
@HemangChothani HemangChothani mentioned this issue Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
api: spanner Issues related to the googleapis/python-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(spanner): add client_options to base class MaxxleLLC/python-spanner
3 participants
@tseaver @busunkim96 @HemangChothani