Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose preconditions to ACL methods #582

Closed
cojenco opened this issue Sep 7, 2021 · 0 comments · Fixed by #586
Closed

Expose preconditions to ACL methods #582

cojenco opened this issue Sep 7, 2021 · 0 comments · Fixed by #586
Assignees
@cojenco
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@cojenco
Copy link
Contributor

cojenco commented Sep 7, 2021

The PATCH API requests for ACL in python-storage utilize storage.buckets.patch or storage.objects.patch, instead of ACL specific endpoints such as storage.bucket_acl.patch storage.object_acl.patch storage.default_object_acl.patch

  • Add preconditions support to the ACL library methods to make the patch operations conditionally idempotent
  • Add retry configuration

Note: IAM configurations storage.buckets.getIamPolicy storage.buckets.setIamPolicy are highly encouraged to control access instead
@cojenco cojenco self-assigned this Sep 7, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 7, 2021
@cojenco cojenco mentioned this issue Sep 7, 2021
Merged
@andrewsg andrewsg added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 9, 2021
@cojenco cojenco mentioned this issue Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cojenco cojenco

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add preconditions and retry config support to ACL patch operationss cojenco/python-storage
2 participants
@andrewsg @cojenco