Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host is not updated when universe domain is specified #2911

Open
JesseLovelace opened this issue Jun 14, 2024 · 0 comments
Open

host is not updated when universe domain is specified #2911

JesseLovelace opened this issue Jun 14, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JesseLovelace
Copy link
Contributor

When a client specifies a universe domain, the host value does not get automatically updated to match. For example, if I create a storage client:

Storage storage = StorageOptions.grpc().setUniverseDomain("my-universe-domain.com").build().getService();

Then
storage.getOptions().getUniverseDomain() properly returns my-universe-domain, but storage.getOptions.getHost() just returns www.googleapis.com, when it should return https://storage.my-universe-domain.com

@lqiu96 lqiu96 self-assigned this Jun 17, 2024
@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 17, 2024
@lqiu96 lqiu96 removed their assignment Sep 16, 2024
@lqiu96 lqiu96 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants