Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using a Mock gRPC Channel for InstantiatingGrpcChannelProviderTest #3017

Open
lqiu96 opened this issue Jul 8, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lqiu96
Copy link
Contributor

lqiu96 commented Jul 8, 2024

Following the flaky test reported in here: #2852, we discovered that some unit tests are creating a gRPC channel. Ideally, we would like to use a mock or stub instead of a real gRPC channel.

This reduces the change for flaky behavior and also would help speed up the tests (creating a channel is ~500ms).

This ticket is to investigate whether we can use a mock or stub instead of an actual channel and implement the change.

@lqiu96 lqiu96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant