Allow the use of quotes in set-[local|session]-storage-item

Related discussion: uBlockOrigin/uAssets#20630 (comment)
gorhill · Nov 13, 2023 · decafc5 · decafc5
1 parent b26d421
commit decafc5
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/assets/resources/scriptlets.js b/assets/resources/scriptlets.js
@@ -848,10 +848,13 @@ function setLocalStorageItemFn(
  value = (new Date()).toISOString();
  }
  } else {
- if ( trustedValues.includes(value.toLowerCase()) === false ) {
- if ( /^\d+$/.test(value) === false ) { return; }
- value = parseInt(value, 10);
- if ( value > 32767 ) { return; }
+ const normalized = value.toLowerCase();
+ const match = /^("?)(.+)\1$/.exec(normalized);
+ const unquoted = match && match[2] || normalized;
+ if ( trustedValues.includes(unquoted) === false ) {
+ if ( /^\d+$/.test(unquoted) === false ) { return; }
+ const integer = parseInt(unquoted, 10);
+ if ( integer > 32767 ) { return; }
  }
  }