Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanmetrics: wire in new metrics_flush_interval field #4614

Closed
tpaschalis opened this issue Jul 27, 2023 · 7 comments · Fixed by #5407
Closed

spanmetrics: wire in new metrics_flush_interval field #4614

tpaschalis opened this issue Jul 27, 2023 · 7 comments · Fixed by #5407
Assignees
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@tpaschalis
Copy link
Member

Request

Since we've updated our OpenTelemetry Collector dependency, we can now wire in a new field available in the spanmetrics processor, metrics_flush_interval.

Use case

This would help with limiting the rate of metrics generation, from every time a trace was received to a preset interval and help users manage their data throughput.

@tpaschalis tpaschalis added enhancement New feature or request type/signals labels Jul 27, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. The issue will not be closed automatically, but a label will be added to it for tracking purposes.

If the opened issue is a bug, check if newer releases have fixed the issue. If the issue is no longer relevant, please feel free to close it.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label Aug 30, 2023
@rfratto
Copy link
Member

rfratto commented Aug 31, 2023

Is this for both Flow mode and static mode?

@shelbyatgrafana
Copy link

shelbyatgrafana commented Aug 31, 2023

@rfratto I believe this is just for static mode if I recall correctly.

I am not sure about flow mode, but if you make any changes to the static agent, please keep me updated.

@foreverest
Copy link

Hey @rfratto @shelbyatgrafana . I'm the one who raised this. We use static mode, currently.

@github-actions github-actions bot removed the stale Issue/PR mark as stale due lack of activity label Sep 1, 2023
@rfratto
Copy link
Member

rfratto commented Sep 1, 2023

For development context, anything added to static mode must also be brought into flow mode, since we're actively working on giving flow mode parity with static mode.

Since the request is for static mode, then the implementation must make sure that both static mode and flow mode are covered.

@nijave
Copy link

nijave commented Sep 21, 2023

I think this was added here 7357b37#diff-e2e63ff69ed7490ea189f8053e03be8b6d74504e8b1f8ec5b4c516e07b9daf28R50 ? (in 0.36.1)

Edit: Looks like maybe this only exists in flow mode, not static mode

@ptodev
Copy link
Contributor

ptodev commented Sep 22, 2023

Flow mode already supports metrics_flush_interval in otelcol.connector.spanmetrics.

During the last time we upgraded our Otel dependencies, I made a conscious decision to refrain from adding new config parameters to Otel components used in Static mode. This was based on the assumption that the components would keep working as they have in the past, and any new parameters would be set to default values by Otel so that components keep working as before. To be honest this assumption is hard to verify, given that #5271 is causing inconvenience for users I will look into adding the metrics_flush_interval config parameter, and will potentially check if other parameters need to be added as well. I think it's likely that #5271 is a missing feature and not a bug, but it shouldn't be too much effort to add it in and improve the customer experience.

@ptodev ptodev added this to the v0.37.0 milestone Sep 22, 2023
@tpaschalis tpaschalis modified the milestones: v0.37.0, v0.38.0 Oct 6, 2023
@ptodev ptodev linked a pull request Oct 6, 2023 that will close this issue
4 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants