Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fails with Go 1.23 #89796

Open
stefanb opened this issue Jun 26, 2024 · 0 comments
Open

Build: Fails with Go 1.23 #89796

stefanb opened this issue Jun 26, 2024 · 0 comments

Comments

@stefanb
Copy link

stefanb commented Jun 26, 2024

What happened?

Trying to build with Go 1.23 (currently rc1, final scheduled in August 2024):

The build failed with error:

  Version: 11.0.0, Linux Version: 11.0.0, Package Iteration: 1719017716
  building binaries build
  building grafana ./pkg/cmd/grafana
  rm -r ./bin/darwin-arm64/grafana
  rm -r ./bin/darwin-arm64/grafana.md5
  go build -ldflags -w -X main.version=11.0.0 -X main.commit=unknown-dev -X main.buildstamp=1715585693 -X main.buildBranch=main -o ./bin/darwin-arm64/grafana ./pkg/cmd/grafana
  go: downloading github.com/urfave/cli/v2 v2.25.0
  go: downloading github.com/grafana/pyroscope-go/godeltaprof v0.1.6
  go: downloading github.com/grafana/authlib v0.0.0-20240319083410-9d4a6e3861e5
  # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame
  exit status 1

This was likely already fixed in

but that needs to be included in a tagged release and updated in Grafana.

What did you expect to happen?

Build to succeed.

Did this work before?

Yes, with previous versions of Go:

How do we reproduce it?

  1. Try to build it with Go 1.23

Is the bug inside a dashboard panel?

No

Environment (with versions)?

Grafana: 11.0.0
OS: Linux
Browser: N/A

Grafana platform?

None

Datasource(s)?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant