From cfa9a6e40cc2969e52c4df1e2926ad53e0a39bad Mon Sep 17 00:00:00 2001 From: Patrick Oyarzun Date: Wed, 1 Jun 2022 15:11:14 -0500 Subject: [PATCH] Disable distributor.extend-writes & ingester.ring.unregister-on-shutdown Signed-off-by: Patrick Oyarzun --- operations/helm/charts/mimir-distributed/CHANGELOG.md | 6 ++++++ operations/helm/charts/mimir-distributed/Chart.yaml | 2 +- operations/helm/charts/mimir-distributed/README.md | 2 +- operations/helm/charts/mimir-distributed/values.yaml | 4 ++++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/operations/helm/charts/mimir-distributed/CHANGELOG.md b/operations/helm/charts/mimir-distributed/CHANGELOG.md index 08e5362cc99..b799159d6b4 100644 --- a/operations/helm/charts/mimir-distributed/CHANGELOG.md +++ b/operations/helm/charts/mimir-distributed/CHANGELOG.md @@ -11,6 +11,12 @@ Entries should be ordered as follows: Entries should include a reference to the Pull Request that introduced the change. +## 2.1.0-beta.5 + +* [ENHANCEMENT] Disable `ingester.ring.unregister-on-shutdown` and `distributor.extend-writes` #1994 + - This will prevent resharding every series during a rolling ingester restart + - Under some circumstances the previous values (both enabled) could cause write path degredation during rolling restarts + ## 2.1.0-beta.4 * [ENHANCEMENT] Add support for the results cache used by the query frontend #1993 diff --git a/operations/helm/charts/mimir-distributed/Chart.yaml b/operations/helm/charts/mimir-distributed/Chart.yaml index 157368742aa..7ed82a643de 100644 --- a/operations/helm/charts/mimir-distributed/Chart.yaml +++ b/operations/helm/charts/mimir-distributed/Chart.yaml @@ -1,5 +1,5 @@ apiVersion: v2 -version: 2.1.0-beta.4 +version: 2.1.0-beta.5 appVersion: 2.0.0 description: "Grafana Mimir" engine: gotpl diff --git a/operations/helm/charts/mimir-distributed/README.md b/operations/helm/charts/mimir-distributed/README.md index 47990bb6735..538d3f6f1ec 100644 --- a/operations/helm/charts/mimir-distributed/README.md +++ b/operations/helm/charts/mimir-distributed/README.md @@ -4,7 +4,7 @@ Helm chart for deploying [Grafana Mimir](https://grafana.com/docs/mimir/v2.0.x/) # mimir-distributed -![Version: 2.1.0-beta.4](https://img.shields.io/badge/Version-2.1.0--beta.4-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square) +![Version: 2.1.0-beta.5](https://img.shields.io/badge/Version-2.1.0--beta.5-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square) Grafana Mimir diff --git a/operations/helm/charts/mimir-distributed/values.yaml b/operations/helm/charts/mimir-distributed/values.yaml index 8f5afba0566..e4379cd114a 100644 --- a/operations/helm/charts/mimir-distributed/values.yaml +++ b/operations/helm/charts/mimir-distributed/values.yaml @@ -100,10 +100,14 @@ mimir: compactor: data_dir: "/data" + distributor: + extend_writes: false + ingester: ring: final_sleep: 0s num_tokens: 512 + unregister_on_shutdown: false ingester_client: grpc_client_config: