Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a default -distributor.ha-tracker.max-clusters #2173

Closed
pracucci opened this issue Jun 22, 2022 · 1 comment · Fixed by #2465
Closed

Set a default -distributor.ha-tracker.max-clusters #2173

pracucci opened this issue Jun 22, 2022 · 1 comment · Fixed by #2465
Assignees
@Rustin170506
Labels
component/distributor good first issue Good for newcomers

Comments

@pracucci
Copy link
Collaborator

The default -distributor.ha-tracker.max-clusters is 0 which means unlimited. We should provide a DoS protection out of the box. At Grafana Labs we use a default of 100, which both offer a good protection as well as is high enough to work for most use cases.

I propose to change its default to 100.
@56quarters 56quarters added the good first issue Good for newcomers label Jul 6, 2022
@Rustin170506
Copy link
Contributor

I am working on this.

@Rustin170506 Rustin170506 mentioned this issue Jul 19, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rustin170506 Rustin170506

Labels
component/distributor good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change default value for -distributor.ha-tracker.max-clusters to 100 Rustin170506/mimir
3 participants
@56quarters @pracucci @Rustin170506