Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimirtool fails to build on Windows #2258

Closed
Tracked by #2241
pstibrany opened this issue Jun 28, 2022 · 3 comments · Fixed by #2273
Closed
Tracked by #2241

Mimirtool fails to build on Windows #2258

pstibrany opened this issue Jun 28, 2022 · 3 comments · Fixed by #2273

Comments

@pstibrany
Copy link
Member

Mimirtool fails to build on Windows when running make BUILD_IN_CONTAINER=true dist

# github.com/grafana/mimir/pkg/storegateway/indexheader/fileutil
pkg/storegateway/indexheader/fileutil/mmap.go:41:12: undefined: mmap
pkg/storegateway/indexheader/fileutil/mmap.go:50:10: undefined: munmap
sha256sum: ./dist/mimirtool-windows-amd64.exe: No such file or directory
Building mimirtool for windows/arm64
# github.com/grafana/mimir/pkg/storegateway/indexheader/fileutil
pkg/storegateway/indexheader/fileutil/mmap.go:41:12: undefined: mmap
pkg/storegateway/indexheader/fileutil/mmap.go:50:10: undefined: munmap
sha256sum: ./dist/mimirtool-windows-arm64.exe: No such file or directory
make: Leaving directory '/go/src/github.com/grafana/mimir'
@pstibrany pstibrany mentioned this issue Jun 28, 2022
7 tasks
@pracucci
Copy link
Collaborator

I got the same issue on OSX, and this PR fixed it: #2054

@colega
Copy link
Contributor

colega commented Jul 14, 2022

@pstibrany can we close this?

@pstibrany
Copy link
Member Author

Yes. I was waiting for next RC and merge to main before closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants