Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimir rejects samples when exemplar is non-compliant #8210

Closed
Tracked by #8223
gouthamve opened this issue May 29, 2024 · 0 comments · Fixed by #8224
Closed
Tracked by #8223

Mimir rejects samples when exemplar is non-compliant #8210

gouthamve opened this issue May 29, 2024 · 0 comments · Fixed by #8224
Assignees

Comments

@gouthamve
Copy link
Member

See

if err := validateExemplar(d.exemplarValidationMetrics, userID, ts.Labels, e); err != nil {
// An exemplar validation error prevents ingesting samples
// in the same series object. However because the current Prometheus
// remote write implementation only populates one or the other,
// there never will be any.
return err
}

We reject the entire sample if the exemplar attached is non-compliant (see: #7904). OTel sends empty exemplars by default and this means OTel users' data is being dropped regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants