Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide Login As button if role lacks login permissions #1862

Closed
aberoham opened this issue Apr 10, 2018 · 1 comment · Fixed by #2168
Closed

hide Login As button if role lacks login permissions #1862

aberoham opened this issue Apr 10, 2018 · 1 comment · Fixed by #2168
Assignees

Comments

@aberoham
Copy link
Contributor

What happened:

A PCI compliance auditor with read-only Teleport RBAC permissions logged in and saw Login As buttons present for all visible nodes, even though their Teleport role only allowed session list & session read. (role below) They didn't want to click Login As without explicit authority, and only once you click the button do you get an error stating that you don't have access.

What you expected to happen:

The interface would hide or otherwise provide better UX around the Login As button if login to any given node is not explicitly allowed.

How to reproduce it (as minimally and precisely as possible):

auditor.yaml: |-
    kind: "role"
    version: "v3"
    metadata:
      name: "auditor"
    spec:
      options:
        # max_session_ttl defines the TTL (time to live) of SSH certificates 
        # issued to the users with this role.
        max_session_ttl: "1h"
      allow:
        rules:
          - resources: [session]
            verbs: [list, read]
      deny:
        node_labels:
          "*": "*"

Environment:

  • Teleport version (use teleport version): 2.5.x Enterprise
  • Tsh version (use tsh version): same
  • OS (e.g. from /etc/os-release): n/a

Browser environment

n/a

Relevant Debug Logs If Applicable

n/a

@aberoham aberoham added this to the 2.6.1 "New Braunfels" milestone May 11, 2018
@russjones russjones modified the milestones: 2.6.1 "New Braunfels", 2.7.0 "San Antonio" May 22, 2018
@alex-kovoy alex-kovoy assigned alex-kovoy and unassigned alexwolfe Aug 13, 2018
@aberoham
Copy link
Contributor Author

TL;DR from in-person discussion with Alexey, If allowed_logins is empty, we could simply not display "Login As", that would suffice for this particular customer ask. The more detailed work to limit node visibility would be handled in #1954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants