Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing on Mac #621

Open
ribalba opened this issue Dec 22, 2023 · 5 comments
Open

Enable testing on Mac #621

ribalba opened this issue Dec 22, 2023 · 5 comments
Assignees

Comments

@ribalba
Copy link
Member

ribalba commented Dec 22, 2023

Currently we only test on ubuntu with the GitHub ci. I would also want to run the Mac tests once in a while. GitHub offers support for 'macos-latest' [0] so adding it shouldn't be that hard.

[0] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners

@ArneTR
Copy link
Member

ArneTR commented Dec 22, 2023

Would be crazy if powermetrics is available there

@dan-mm Can you check that out please?

@dan-mm
Copy link
Contributor

dan-mm commented Jan 8, 2024

Didi started it here -
#635

I can take over from here - next step is to SSH into the runner and try manually to see why it didn't just work out of the box

@dan-mm
Copy link
Contributor

dan-mm commented Jan 12, 2024

Quick update as to why its not working: docker isn't installed by default on Mac github runners, it seems:

Building / Updating docker containers
./install_mac.sh: line 137: docker: command not found

@ArneTR
Copy link
Member

ArneTR commented Jan 12, 2024

@dan-mm
Copy link
Contributor

dan-mm commented Jan 12, 2024

I'm already on it - while in the SSH session I installed docker and got through the install_mac.sh script successfully. updating the workflows now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants