Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat differently OperationCanceledException raised as the result of cancellation initiated by the client. #2218

Closed
voroninp opened this issue Aug 1, 2023 · 0 comments · Fixed by #2221
Closed

Treat differently OperationCanceledException raised as the result of cancellation initiated by the client. #2218

voroninp opened this issue Aug 1, 2023 · 0 comments · Fixed by #2221
Labels
enhancement New feature or request

Comments

@voroninp
Copy link
Contributor

voroninp commented Aug 1, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

When a client cancels the request, I see message logged {Id: 17, Name: 'ErrorSendingMessage'}. IMO, while still being an exception, it should not be treated as an error per se.

Describe the solution you'd like

I'd prefer to have a separate event. MessageNotSentOperationCancelled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistently don't log message errors on cancellation JamesNK/grpc-dotnet
1 participant
@voroninp