Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs use absolute links #842

Open
chalin opened this issue Aug 21, 2021 · 0 comments
Open

Breadcrumbs use absolute links #842

chalin opened this issue Aug 21, 2021 · 0 comments

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 21, 2021

For example, visit https://grpc.io/docs/languages/, and inspect the breadcrumb for Documentation. This is the HTML associated with the breadcrumbs:

<nav aria-label="breadcrumb" class="d-print-none">
  <ol class="breadcrumb spb-1">
    <li class="breadcrumb-item"><a href="https://grpc.io/docs/">Documentation</a></li>
    <li class="breadcrumb-item active" aria-current="page"><a href="https://grpc.io/docs/languages/">Languages</a></li>
  </ol>
</nav>

This isn't an issue pre se, just a bit surprising: and it burdens the link checker when checking external links. Since we're already overriding the layout, we could switch to using relative links.

Resources:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant