From d376bc66a41c4214c8f93e641dc2d4d142c07f62 Mon Sep 17 00:00:00 2001 From: Wai Sing Yiu Date: Tue, 17 Sep 2024 17:22:29 +0100 Subject: [PATCH] Add headingStyle and replace title --- proto/blueprint.proto | 21 ++++++++++++++++++++- proto/proto.lock | 40 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 59 insertions(+), 2 deletions(-) diff --git a/proto/blueprint.proto b/proto/blueprint.proto index 2183a2d..80791fe 100644 --- a/proto/blueprint.proto +++ b/proto/blueprint.proto @@ -96,11 +96,30 @@ message Collection { * the header is rendered in smaller size to show they are child * sections within a main collection. */ - optional bool small_heading = 16; + optional bool small_heading = 16 [deprecated = true]; optional AdTargetingParams ad_targeting_params = 17; optional string ad_unit = 18; + + /** + * This tells the app in which style to display, or not display, + * the title. + */ + enum HeadingStyle { + HEADING_STYLE_UNSPECIFIED = 0; + HEADING_STYLE_HIDDEN = 1; + HEADING_STYLE_REGULAR = 2; + HEADING_STYLE_SMALL = 3; + } + optional HeadingStyle headingStyle = 19; + + /** + * The title of this collection for display. It replaces + * the old "title" property. + */ + optional string displayTitle = 20; + } /** diff --git a/proto/proto.lock b/proto/proto.lock index 8f144a6..e896d4d 100644 --- a/proto/proto.lock +++ b/proto/proto.lock @@ -24,6 +24,26 @@ } ] }, + { + "name": "Collection.HeadingStyle", + "enum_fields": [ + { + "name": "HEADING_STYLE_UNSPECIFIED" + }, + { + "name": "HEADING_STYLE_HIDDEN", + "integer": 1 + }, + { + "name": "HEADING_STYLE_REGULAR", + "integer": 2 + }, + { + "name": "HEADING_STYLE_SMALL", + "integer": 3 + } + ] + }, { "name": "FollowUp.FollowUpType", "enum_fields": [ @@ -413,7 +433,13 @@ "id": 16, "name": "small_heading", "type": "bool", - "optional": true + "optional": true, + "options": [ + { + "name": "deprecated", + "value": "true" + } + ] }, { "id": 17, @@ -426,6 +452,18 @@ "name": "ad_unit", "type": "string", "optional": true + }, + { + "id": 19, + "name": "headingStyle", + "type": "HeadingStyle", + "optional": true + }, + { + "id": 20, + "name": "displayTitle", + "type": "string", + "optional": true } ] },