Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notice] graceful-fs deprecation warning #1571

Closed
phated opened this issue Mar 17, 2016 · 6 comments
Closed

[Notice] graceful-fs deprecation warning #1571

phated opened this issue Mar 17, 2016 · 6 comments

Comments

@phated
Copy link
Member

phated commented Mar 17, 2016

We are aware of the graceful-fs deprecation warning upon install of gulp 3.x.

This is due to:

  1. A transitive graceful-fs devDependency

We are unable to upgrade due to API breaking changes.

There is nothing wrong with the dependency, especially since it is only used in development. We will be updating or removing it in gulp 4 and the message will go away.

Please do not open issues about this topic.
Thank you,
-The gulp team

@phated phated added the notice label Mar 17, 2016
@gulpjs gulpjs locked and limited conversation to collaborators Mar 17, 2016
@phated phated modified the milestone: gulp 4 Apr 5, 2016
@callumacrae callumacrae mentioned this issue Apr 18, 2016
@phated
Copy link
Member Author

phated commented Aug 16, 2016

This should be no longer an issue due to the amazing work by @thealphanerd at isaacs/node-graceful-fs@07701dc

I'll leave this open until I have a chance to verify. Unlocking incase anyone has a chance to test it out.

@gulpjs gulpjs unlocked this conversation Aug 16, 2016
@piotr-cz
Copy link

how to test?

@phated
Copy link
Member Author

phated commented Aug 16, 2016

Looks like there was a follow up at isaacs/node-graceful-fs@07701dc#commitcomment-18659275

Locking again with the same conclusion. Sorry everyone.

@gulpjs gulpjs locked and limited conversation to collaborators Aug 16, 2016
@phated
Copy link
Member Author

phated commented Aug 24, 2016

As per #1760 (comment) - It looks like I can close this now that graceful-fs 3.0.10 has been released.

@phated phated closed this as completed Aug 24, 2016
@phated
Copy link
Member Author

phated commented Oct 6, 2016

Looks like I need to reopen this 😦

@phated phated reopened this Oct 6, 2016
@phated phated marked this as a duplicate of #1959 Jul 19, 2017
@phated
Copy link
Member Author

phated commented Jan 1, 2018

gulp 4 has been published under the next tag (npm install gulp@next) so I'm going to close this.

@phated phated closed this as completed Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants