Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should make a cleanly-vectorizing fast-approximation for atan2f. #8243

Open
mcourteaux opened this issue May 29, 2024 · 4 comments
Open
Assignees

Comments

@mcourteaux
Copy link
Contributor

This article seems amazing reference:

https://mazzo.li/posts/vectorized-atan2.html

You may assign me, I think I'll do it. I think I'm seeing bad performance due to 8 calls to glibc's atan2f, instead of something that vectorizes cleanly.

@mcourteaux
Copy link
Contributor Author

@steven-johnson
Copy link
Contributor

Tagging zvookin because he's looked into doing this for some other similar cases (eg tanh)

@steven-johnson
Copy link
Contributor

Tagging @mcourteaux because nothing has happened -- assign to me instead if you don't have bandwidth

@mcourteaux
Copy link
Contributor Author

Assigning me is great! I just wanted to turn this idea into an issue, and have me assigned. It's still on my backlog. Will definitely get to this, but it's low priority right now. Somewhere in the coming month or two ideally.

PS: I cannot assign anyone. I don't have those permissions, it seems. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants