unite appears to break suspend

[rvertesi]

With unite enabled, my laptop won't go into sleep but (randomly for the 2nd or 3rd time) it stays turned on and and locks up.
I have a Thinkpad L380, running Ubuntu 18.04.3 with 5.0.0-32-generic (also tried with 4.15).
So currently I cannot use Unite. Please tell if you need any further information.

Expected behavior:

1. closing the lid makes the computer enter suspend, after opening it prompts for password then resumes.
2. pressing suspend button/calling pm-suspend turns screen off, sends laptop to sleep. Pressing the power button it resumes.

Experienced behavor:

1. by closing the lid the computer keeps running. opening the lid the screen is blank.
2. the machine immediately prompts for the password, then locks up.
   In both cases the light responds to FnLock on/off, but nothing happens for Alt+Ctrl+F2...8 or even Ctrl+Alt+Backspace. Only a hard reset (power button 5 seconds) helps.

Workaround: disable the Unite extension.

[jonian]

@rvertesi I have not been able to reproduce this. I you still use this extension, do you still have this issue with the latest version?

[jonian]

Closing due to no response. If the issue persists, please open a new issue.

[peci1]

This is also happening to me. Even if I don't close the lid but press the sleep button in UI (Ubuntu 18.04). The lock screen appears, but the computer doesn't go to sleep. Unlocking the screen or switching to a VT helps continuing the sleep operation. But that's unfortunate, because when I unlock the screen before sleep, then the computer would wake up unlocked. Moreover, in I would say 90% of cases, resuming from such sleep would not succeed and the computer completely freezes.

I'm seeing this exception in the logs around suspend, but I'm not sure it's related:

gnome-shell[7499]: Object Shell.GenericContainer (0x558c54c48f50), has been already deallocated - impossible to access it. This might be caused by the object having been destroyed 
org.gnome.Shell.desktop[7499]: == Stack trace for context 0x558c4f32f320 ==
org.gnome.Shell.desktop[7499]: #0 0x558c4f773ca8 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/modules/themeMods.js:120 (0x7f01eec65ab0 @ 98)
org.gnome.Shell.desktop[7499]: #1 0x7ffef1a9d730 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #2 0x558c4f773c18 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/modules/themeMods.js:140 (0x7f01eec65b38 @ 41)
org.gnome.Shell.desktop[7499]: #3 0x7ffef1a9e320 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #4 0x558c4f773b68 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/modules/themeMods.js:157 (0x7f01eec65bc0 @ 253)
org.gnome.Shell.desktop[7499]: #5 0x7ffef1a9ef10 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #6 0x558c4f773ad8 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/modules/themeMods.js:174 (0x7f01eec65cd0 @ 62)
org.gnome.Shell.desktop[7499]: #7 0x7ffef1a9faf0 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #8 0x558c4f773a40 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/modules/themeMods.js:40 (0x7f01eec65670 @ 383)
org.gnome.Shell.desktop[7499]: #9 0x7ffef1aa06d0 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #10 0x7ffef1aa0770 b   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/module.js:41 (0x7f01eec23a28 @ 39)
org.gnome.Shell.desktop[7499]: #11 0x7ffef1aa07d0 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #12 0x558c4f7739b8 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/module.js:46 (0x7f01eec23ab0 @ 37)
org.gnome.Shell.desktop[7499]: #13 0x7ffef1aa13b0 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #14 0x558c4f773920 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/module.js:19 (0x7f01eec23890 @ 129)
org.gnome.Shell.desktop[7499]: #15 0x7ffef1aa1f90 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #16 0x558c4f773890 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/extension.js:28 (0x7f01eec23450 @ 227)
org.gnome.Shell.desktop[7499]: #17 0x7ffef1aa2fb0 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #18 0x558c4f773808 i   /home/peci1/.local/share/gnome-shell/extensions/unite@hardpixel.eu/extension.js:52 (0x7f01eec23560 @ 15)
org.gnome.Shell.desktop[7499]: #19 0x7ffef1aa40c0 b   resource:///org/gnome/shell/ui/extensionSystem.js:135 (0x7f026c459340 @ 509)
org.gnome.Shell.desktop[7499]: #20 0x558c4f773788 i   resource:///org/gnome/shell/ui/extensionSystem.js:342 (0x7f026c459c48 @ 13)
org.gnome.Shell.desktop[7499]: #22 0x558c4f773708 i   resource:///org/gnome/shell/ui/extensionSystem.js:341 (0x7f026c459bc0 @ 76)
org.gnome.Shell.desktop[7499]: #23 0x558c4f773688 i   resource:///org/gnome/shell/ui/extensionSystem.js:369 (0x7f026c459de0 @ 67)
org.gnome.Shell.desktop[7499]: #24 0x7ffef1aa5c20 I   resource:///org/gnome/gjs/modules/signals.js:128 (0x7f026c5d2230 @ 386)
org.gnome.Shell.desktop[7499]: #25 0x7ffef1aa5ce0 b   resource:///org/gnome/shell/ui/sessionMode.js:205 (0x7f026c1704d8 @ 254)
org.gnome.Shell.desktop[7499]: #26 0x7ffef1aa5d40 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #27 0x558c4f7735f8 i   resource:///org/gnome/shell/ui/sessionMode.js:174 (0x7f026c170340 @ 100)
org.gnome.Shell.desktop[7499]: #28 0x7ffef1aa6920 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #29 0x558c4f773550 i   resource:///org/gnome/shell/ui/screenShield.js:1212 (0x7f026c153918 @ 159)
org.gnome.Shell.desktop[7499]: #30 0x7ffef1aa7500 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #31 0x558c4f7734d0 i   resource:///org/gnome/shell/ui/screenShield.js:1198 (0x7f026c153890 @ 17)
org.gnome.Shell.desktop[7499]: #32 0x558c4f773448 i   resource:///org/gnome/shell/gdm/authPrompt.js:501 (0x7f026c181120 @ 61)
org.gnome.Shell.desktop[7499]: #33 0x7ffef1aa8790 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #34 0x558c4f7733c0 i   resource:///org/gnome/shell/ui/unlockDialog.js:147 (0x7f026c18e5e8 @ 25)
org.gnome.Shell.desktop[7499]: #35 0x7ffef1aa9370 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71)
org.gnome.Shell.desktop[7499]: #36 0x558c4f773340 i   resource:///org/gnome/shell/ui/screenShield.js:1198 (0x7f026c153808 @ 46)
org.gnome.Shell.desktop[7499]: #37 0x7ffef1aa9f50 I   resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7f026c5b5de0 @ 71) 
org.gnome.Shell.desktop[7499]: #38 0x558c4f7732c0 i   resource:///org/gnome/shell/ui/screenShield.js:540 (0x7f026c14fef0 @ 13)
org.gnome.Shell.desktop[7499]: #39 0x7ffef1aaab60 I   resource:///org/gnome/gjs/modules/signals.js:128 (0x7f026c5d2230 @ 386)
org.gnome.Shell.desktop[7499]: #40 0x558c4f773220 i   resource:///org/gnome/gjs/modules/overrides/Gio.js:117 (0x7f026c5e0ab0 @ 39)

[peci1]

Okay, so the sleep errors were caused by the super-outdated ubuntu-appindicators that ship with Ubuntu 18.04. But the exception I reported stays.

[jonian]

Hi @peci1, thanks for the report. What version of ubuntu are you using? Your unite version is very old. Can you update to the latest version?

[peci1]

I'm on ubuntu 18.04. https://extensions.gnome.org/local/ doesn't offer me any updates for my version of system, so I thought this is the latest compatible one... should master work on 18.04?

[jonian]

Master branch is compatible with gnome shell >= 3.32. Earlier versions of gnome shell are no longer supported. What is the gnome shell version on ubuntu 18.04?

[peci1]

It's 3.28...