Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_guardduty_detector RDS support #28229

Closed
cvlc opened this issue Dec 7, 2022 · 14 comments · Fixed by #31463
Closed

[Enhancement]: aws_guardduty_detector RDS support #28229

cvlc opened this issue Dec 7, 2022 · 14 comments · Fixed by #31463
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/guardduty Issues and PRs that pertain to the guardduty service.
Milestone

Comments

@cvlc
Copy link

cvlc commented Dec 7, 2022

Description

Amazon GuardDuty RDS protection is now in feature preview but the Terraform resource does not yet support it.

It would be great if it was supported by the Terraform resource so it could be easily enabled for those using GuardDuty and the most popular IaaC tool.

Affected Resource(s) and/or Data Source(s)

  • resource: aws_guardduty_detector
  • data: aws_guardduty_detector

Potential Terraform Configuration

resource "aws_guardduty_detector" "MyDetector" {
  enable = true

  datasources {
    s3_logs {
      enable = true
    }
    rds {
      enable = true
    }
    kubernetes {
      audit_logs {
        enable = false
      }
    }
    malware_protection {
      scan_ec2_instance_with_findings {
        ebs_volumes {
          enable = true
        }
      }
    }
  }
}

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/guardduty_detector
https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-guardduty-rds-protection-preview/
https://docs.aws.amazon.com/guardduty/latest/ug/rds-protection.html

Would you like to implement a fix?

None

@cvlc cvlc added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/guardduty Issues and PRs that pertain to the guardduty service. label Dec 7, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 23, 2023
@javierbeaumont
Copy link
Contributor

Please, same enhancement for aws_guardduty_organization_configuration resource.

@pippin-wallace
Copy link

Does this need to be out of preview prior to being supported?

@theonlysinjin
Copy link

theonlysinjin commented Mar 8, 2023

Bumped into this now too.

Is the issue that there is no way to enable it via the API like the others?
If I look at the aws api docs it's not listed.

And as part of the GuardDuty docs mentioned above, the RDS page only has a console method to enable it, the others have API examples.

@lawliet89
Copy link
Contributor

This feature has gone GA: https://aws.amazon.com/about-aws/whats-new/2023/03/amazon-guardduty-rds-protection-aurora-generally-available/

@lawliet89
Copy link
Contributor

lawliet89 commented Mar 24, 2023

At the time of writing, this option is (still) missing from the API and is not possible to implement: https://docs.aws.amazon.com/guardduty/latest/APIReference/API_DataSourceConfigurations.html

image

@ttmh1001
Copy link

ttmh1001 commented Mar 27, 2023

Documentation for the MemberFeaturesConfiguration is now updated for RDS_LOGIN_EVENTS, strangely enough the documentation for DataSourceConfigurations is still missing this?
https://docs.aws.amazon.com/guardduty/latest/APIReference/API_MemberFeaturesConfiguration.html

GuardDuty MemberFeaturesConfiguration

Does this mean we will see the Terraform GuardDuty Detector support this soon?
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/guardduty_detector

@sakojun
Copy link

sakojun commented Mar 29, 2023

The use of dataSources is deprecated and the use of features is recommended.
https://docs.aws.amazon.com/guardduty/latest/ug/guardduty-feature-object-api-changes-march2023.html

@Galal-Eltfawy
Copy link

any plans for adding RDS protection and EKS runtime monitoring?

@cookiesowns
Copy link

Bump. Would be great to get the EKS runtime monitoring flags for guardduty As otherwise the EKS guardduty addon resource will fail to create in terraform if you don't already have it enabled.

@cyn110
Copy link

cyn110 commented Jun 14, 2023

Bump please now that GuardDuty RDS is officially launched.

@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 25, 2023
@breathingdust breathingdust changed the title [Enhancement]: aws_guardduty_detector RDS preview support [Enhancement]: aws_guardduty_detector RDS support Aug 4, 2023
@ewbankkit ewbankkit self-assigned this Sep 26, 2023
@ewbankkit
Copy link
Contributor

You will be able to use the upcoming aws_guardduty_detector_feature resource (#31463):

resource "aws_guardduty_detector" "example" {
  enable = true
}

resource "aws_guardduty_detector_feature" "example" {
  detector_id = aws_guardduty_detector.example.id
  name        = "RDS_LOGIN_EVENTS"
  status      = "ENABLED"
}

@github-actions github-actions bot added this to the v5.20.0 milestone Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/guardduty Issues and PRs that pertain to the guardduty service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.