Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Apply IAM Access Analyzer archive rules to existing findings #32112

Open
Dave-Snigier opened this issue Jun 20, 2023 · 1 comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service.

Comments

@Dave-Snigier
Copy link

Description

When updating or creating IAM Access Analyzer archive rules we should have a way to apply these to existing findings when the resource is created or updated.

Currently, the rules are only applied to new findings, and we must manually run the apply function outside of Terraform when the rules are created or updated.

When updating the rules through the AWS web console, they provide this option so it should be in line with user expectations.

The default option for this should probably be False, as this is the current behavior.

Affected Resource(s) and/or Data Source(s)

  • aws_accessanalyzer_archive_rule

Potential Terraform Configuration

resource "aws_accessanalyzer_archive_rule" "example" {
  apply_to_existing = True

  analyzer_name = "example-analyzer"
  rule_name     = "example-rule"

  filter {
    criteria = "condition.aws:UserId"
    eq       = ["userid"]
  }
}

References

AWS API Documentation | ApplyArchiveRule

Would you like to implement a fix?

No

@Dave-Snigier Dave-Snigier added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jun 20, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. label Jun 20, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service.
Projects
None yet
Development

No branches or pull requests

2 participants