Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add StructuredLogDestinations Support to Transfer Server #32653

Closed
calvine opened this issue Jul 23, 2023 · 4 comments · Fixed by #32654
Closed

[Enhancement]: Add StructuredLogDestinations Support to Transfer Server #32653

calvine opened this issue Jul 23, 2023 · 4 comments · Fixed by #32654
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Milestone

Comments

@calvine
Copy link
Contributor

calvine commented Jul 23, 2023

Description

I am looking to add support for structured logging destinations to the aws transfer server resource. Adding this property will allow users to enable structured logs from terraform for the transfer server and reap the various benefits such as the ones listed here.

Affected Resource(s) and/or Data Source(s)

aws_transfer_server

Potential Terraform Configuration

terraform {
  required_providers {
    aws = {
      source = "hashicorp/aws"
    }
  }
}

resource "aws_cloudwatch_log_group" "transfer" {
  name_prefix = "transfer_test_"
}

data "aws_iam_policy_document" "transfer_assume_role" {
  statement {
    effect = "Allow"

    principals {
      type        = "Service"
      identifiers = ["transfer.amazonaws.com"]
    }

    actions = ["sts:AssumeRole"]
  }
}

resource "aws_iam_role" "iam_for_transfer" {
  name_prefix         = "iam_for_transfer_"
  assume_role_policy  = data.aws_iam_policy_document.transfer_assume_role.json
  managed_policy_arns = ["arn:aws:iam::aws:policy/service-role/AWSTransferLoggingAccess"]
}

resource "aws_transfer_server" "transfer" {
  endpoint_type = "PUBLIC"
  logging_role  = aws_iam_role.iam_for_transfer.arn
  protocols     = ["SFTP"]
  structured_log_destinations = [
    "${aws_cloudwatch_log_group.transfer.arn}:*"
  ]
}

References

The StructuredLoggingDestinations property on the CreateServerInput and the UpdateServerInput on the transfer module is what I am looking to add. Here is a link to the CreateServerInput type for the transfer.CreateServer call:

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/transfer#CreateServerInput

Would you like to implement a fix?

Yes

@calvine calvine added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jul 23, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. service/logs Issues and PRs that pertain to the logs service. service/transfer Issues and PRs that pertain to the transfer service. labels Jul 23, 2023
@ewbankkit ewbankkit removed service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. service/logs Issues and PRs that pertain to the logs service. labels Jul 24, 2023
@ewbankkit
Copy link
Contributor

Announcement.

@github-actions github-actions bot added this to the v5.10.0 milestone Jul 25, 2023
@github-actions
Copy link

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants