Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_ecs_task_definition improperly changes the first character of labels to lowercase when specified in dockerLabels in the container definition #38782

Closed
mvallim opened this issue Aug 9, 2024 · 5 comments · Fixed by #38804
Assignees
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@mvallim
Copy link

mvallim commented Aug 9, 2024

Terraform Core Version

1.5.7

AWS Provider Version

5.61.0

Affected Resource(s)

  • aws_ecs_task_definition (container definition)

Expected Behavior

When I specify the labels in the container definition using aws_ecs_task_definition, it is expected that the provider does not alter the label.

resource "aws_ecs_task_definition" "task_definition_default" {
  ...
  container_definitions = jsonencode({
    dockerLabels = {
      "PROMETHEUS_TARGET"            = "true"
      "PROMETHEUS_EXPORTER_PORT"     = "12345"
      "PROMETHEUS_EXPORTER_PATH"     = "/prometheus"
      "PROMETHEUS_EXPORTER_JOB_NAME" = "my-job"
    }
  })
  ...
}

Actual Behavior

After applying, I observe that the container definition of the task is changed to:

...
  "stopTimeout": 120,
  "dockerLabels": {
      "pROMETHEUS_TARGET": "true",
      "pROMETHEUS_EXPORTER_PORT": "12345",
      "pROMETHEUS_EXPORTER_PATH": "/prometheus",
      "pROMETHEUS_EXPORTER_JOB_NAME": "my-job"
  }
...

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_ecs_task_definition" "task_definition_default" {
  ...
  container_definitions = jsonencode({
    dockerLabels = {
      "PROMETHEUS_TARGET"            = "true"
      "PROMETHEUS_EXPORTER_PORT"     = "12345"
      "PROMETHEUS_EXPORTER_PATH"     = "/prometheus"
      "PROMETHEUS_EXPORTER_JOB_NAME" = "my-job"
    }
  })
  ...
}

Steps to Reproduce

Using labels on dockerLabels

resource "aws_ecs_task_definition" "task_definition_default" {
  ...
  container_definitions = jsonencode({
    dockerLabels = {
      "PROMETHEUS_TARGET"            = "true"
      "PROMETHEUS_EXPORTER_PORT"     = "12345"
      "PROMETHEUS_EXPORTER_PATH"     = "/prometheus"
      "PROMETHEUS_EXPORTER_JOB_NAME" = "my-job"
    }
  })
  ...
}

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

@mvallim mvallim added the bug Addresses a defect in current functionality. label Aug 9, 2024
@github-actions github-actions bot added the service/ecs Issues and PRs that pertain to the ecs service. label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 9, 2024
@ewbankkit ewbankkit added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
@ewbankkit
Copy link
Contributor

Relates #38543.
Relates #38622.
Relates #38380.
Relates #38016.

Copy link

github-actions bot commented Aug 9, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.63.0 milestone Aug 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
2 participants