Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscc_quicksight_analysis and dashboard resources missing Definition attribute #1008

Open
vaniita opened this issue Jun 19, 2023 · 3 comments

Comments

@vaniita
Copy link

vaniita commented Jun 19, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Affected Resource(s)

  • awscc_quicksight_analysis
  • awscc_quicksight_dashboard

References

Analysis -> Definition = AnalysisDefinition
is missing from the resource generator and schema

Dashboard -> Definition = DashboardVersionDefinition
is missing from the resource generator and schema

Please see Terraform Provider Schema Issue for the problem overview and two potential solutions

@ewbankkit
Copy link
Contributor

@vaniita Thanks for raising this issue 👏.

We have been suppressing schema updates for

  • AWS::QuickSight::Analysis
  • AWS::QuickSight::Dashboard
  • AWS::QuickSight::DataSet
  • AWS::QuickSight::Template

as the generated Terraform schema Go code fails to compile with errors such as

25:25: internal compiler error: NewBulk too big: nbit=29982 count=729981 nword=937 size=683992197

Please file a bug report including a short program that triggers the error.
https://go.dev/issue/new

@ewbankkit
Copy link
Contributor

Most immediately we can look at increasing GitHub Action runner size to see if we can compile the generated code.

@ewbankkit
Copy link
Contributor

It seems that it's not build machine memory that is the limiting factor here, more size limits on maps inside the Go compiler.
We will need to investigate changes to the Terraform schema code generator -- e.g. generate multiple sub-schemas that reference each other rather a single large schema object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants