Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nodepool-labels in azurerm_kubernetes_cluster_node_pool #6051

Closed
ghost opened this issue Mar 10, 2020 · 3 comments
Closed

Add support for nodepool-labels in azurerm_kubernetes_cluster_node_pool #6051

ghost opened this issue Mar 10, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Mar 10, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Node pools now support custom labels that can be passed via the API and CLI. CLI related PR here: Azure/azure-cli#12418

New or Affected Resource(s)

  • azurerm_kubernetes_cluster_node_pool

Potential Terraform Configuration

azurerm_kubernetes_cluster_node_pool {
  name                  = "internal"
  kubernetes_cluster_id = azurerm_kubernetes_cluster.example.id
  vm_size               = "Standard_DS2_v2"
  node_count            = 1
  nodepool_labels = {
    environment = "Prod"
    size = "Medium"
  }
}

This configuration structure would match the labeling structure used by the kubernetes provider for labels.

References

@dstrebel
Copy link
Contributor

dstrebel commented Mar 11, 2020

Merged in PR #5531

@tombuildsstuff
Copy link
Contributor

Fixed via #5531

@ghost
Copy link

ghost commented May 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants