Option to snapshot disk before destroy

[tammersaleh]

Affected Resource(s)

• google_compute_instance

Much like hashicorp/terraform-provider-aws#2715, I'd love to see a termination_snapshot_name option that takes a final snapshot before destroying a disk. I imagine this makes most sense as an option under the boot_disk and attached_disk structures on google_compute_instance, but I could also see it being an option on google_compute_disk, directly.

This should kick off snapshots any time GCP intends to deprovision the disk, including when the attached instance is decommissioned, and the user hasn't yet learned to set auto_delete to false.

[johananl]

I can take this one, too.

[mitj04]

b/263474622

[rileykarson]

This is a significant amount of client code for an entirely custom behaviour. I don't think we'd want to make a change of this type- this would make sense in the API layer.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.