Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pod service account instead of provided JWT for authentication #95

Closed
omerlh opened this issue Jul 29, 2020 · 1 comment
Closed

Use pod service account instead of provided JWT for authentication #95

omerlh opened this issue Jul 29, 2020 · 1 comment

Comments

@omerlh
Copy link

omerlh commented Jul 29, 2020

Right now the auth method relies on token_reviewer_jwt as a way to supply the JWT for authentication. This makes it a lot harder to config when running the config as code (e.g. using Terraform). Why not just used the service account used by the pod? This is also support token projection API, which renew the tokens. Maybe this can be another config option? I'll be happy to open a PR
@gavinelder gavinelder mentioned this issue Mar 17, 2021
Closed
@tsaarni tsaarni mentioned this issue Oct 14, 2021
Merged
3 tasks
@tvoran
Copy link
Member

tvoran commented Feb 8, 2022

I believe this was covered by #122; closing for now.

@tvoran tvoran closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tvoran @omerlh