You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In #11517, the ability to notify systemd with the status of the vault server was added but the default Vault systemd unit file provided in the official packages does not set Type=notify so this feature doesn't ever get used when installing through package managers.
I only happened to realize this was even a feature due to having debug logs enabled on a dev environment where I saw the log message saying would have sent systemd notification (systemd not present) and got a bit worried since this machine definitely is a systemd box. Took a bit of digging to find the commit adding this and the comment about the systemd service having to have the Type=notify in it.
I don't see any reason that the unit file for Vault shouldn't be updated with Type=notify set and am happy to open a PR if there aren't any objections to it.
To Reproduce
Steps to reproduce the behavior:
Install vault from the official Apt repos
Start vault with debug logging enabled
Notice the message would have sent systemd notification (systemd not present) shortly after starting up.
Run systemctl edit vault and paste the code below in the editor and save.
[Service]
Type=notify
Run systemctl daemon-reload && systemctl restart vault and you will now see the message sent systemd notification: notification=READY=1
Expected behavior
Vault's systemd unit file should properly configure it's type as notify when installed from a package.
Environment:
Vault Server Version: 1.9.4
Vault CLI Version: 1.9.4
Server Operating System/Architecture: Ubuntu 20.04 AMD64
Describe the bug
In #11517, the ability to notify systemd with the status of the vault server was added but the default Vault systemd unit file provided in the official packages does not set
Type=notify
so this feature doesn't ever get used when installing through package managers.I only happened to realize this was even a feature due to having debug logs enabled on a dev environment where I saw the log message saying
would have sent systemd notification (systemd not present)
and got a bit worried since this machine definitely is a systemd box. Took a bit of digging to find the commit adding this and the comment about the systemd service having to have theType=notify
in it.I don't see any reason that the unit file for Vault shouldn't be updated with
Type=notify
set and am happy to open a PR if there aren't any objections to it.To Reproduce
Steps to reproduce the behavior:
would have sent systemd notification (systemd not present)
shortly after starting up.systemctl edit vault
and paste the code below in the editor and save.systemctl daemon-reload && systemctl restart vault
and you will now see the messagesent systemd notification: notification=READY=1
Expected behavior
Vault's systemd unit file should properly configure it's type as
notify
when installed from a package.Environment:
Vault server configuration file(s):
The text was updated successfully, but these errors were encountered: