Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.0.0-beta.2][mssql] Sql query fails on building json with aggregate and __typename on every level #7130

Closed
kkumor opened this issue Jun 28, 2021 · 1 comment
Labels
k/bug Something isn't working p/high candidate for being included in the upcoming sprint

Comments

@kkumor
Copy link

kkumor commented Jun 28, 2021

There is an issue why we want to build an query with __typename and aggregation. __typename is added by default by Appollo client for caching purposes.
There is workaround that you can use with Appollo by changing clients settings, but probably this may affect performance.
inMemoryCacheOptions: { addTypename: false }
Same query works fine with PostreSQL.

image

And here is a bit of my investigation with SQL profiler and potential way to fix this.
First is a query that Hasura is sending right now and second one is maybe a query that you want to send.
image

@0x777 0x777 added k/bug Something isn't working p/high candidate for being included in the upcoming sprint labels Jul 13, 2021
@0x777
Copy link
Member

0x777 commented Jul 30, 2021

The fix has landed on master. It'll be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/bug Something isn't working p/high candidate for being included in the upcoming sprint
Projects
None yet
Development

No branches or pull requests

2 participants