From e2f04388ba85d441f18f77102b16049addc01718 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harold=20Ju=C3=A1rez?= Date: Tue, 18 Jun 2019 14:51:14 -0600 Subject: [PATCH] [statistics] Add extra validation (#357) --- src/EventSubscriber/SaveStatisticsListener.php | 9 +++++++-- src/EventSubscriber/SendStatisticsListener.php | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/EventSubscriber/SaveStatisticsListener.php b/src/EventSubscriber/SaveStatisticsListener.php index 4c2d40a..b8a651a 100644 --- a/src/EventSubscriber/SaveStatisticsListener.php +++ b/src/EventSubscriber/SaveStatisticsListener.php @@ -74,8 +74,13 @@ public function saveStatistics(ConsoleTerminateEvent $event) $configGlobalAsArray = $this->configurationManager->getConfigGlobalAsArray(); - //Validate if the config is enable. - if (is_null($configGlobalAsArray) || !$configGlobalAsArray['application']['statistics']['enabled']) { + //Validate if the config is defined. + if (is_null($configGlobalAsArray) || !isset($configGlobalAsArray['application']['statistics'])) { + return; + } + + //Validate if the statistics is enabled. + if (!isset($configGlobalAsArray['application']['statistics']['enabled']) || !$configGlobalAsArray['application']['statistics']['enabled']) { return; } diff --git a/src/EventSubscriber/SendStatisticsListener.php b/src/EventSubscriber/SendStatisticsListener.php index f83129b..ed66f1e 100644 --- a/src/EventSubscriber/SendStatisticsListener.php +++ b/src/EventSubscriber/SendStatisticsListener.php @@ -67,8 +67,13 @@ public function calculateStatistics(ConsoleTerminateEvent $event) $date = date('Y-m-d'); $configGlobalAsArray = $this->configurationManager->getConfigGlobalAsArray(); - //Validate if the config is enable. - if (is_null($configGlobalAsArray) || !$configGlobalAsArray['application']['statistics']['enabled']) { + //Validate if the config is defined. + if (is_null($configGlobalAsArray) || !isset($configGlobalAsArray['application']['statistics'])) { + return; + } + + //Validate if the statistics is enabled. + if (!isset($configGlobalAsArray['application']['statistics']['enabled']) || !$configGlobalAsArray['application']['statistics']['enabled']) { return; }