Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoother Pan Gesture? #23

Open
loasjerry opened this issue Dec 18, 2013 · 9 comments
Open

Smoother Pan Gesture? #23

loasjerry opened this issue Dec 18, 2013 · 9 comments

Comments

@loasjerry
Copy link

I found that I can't pan the image smoothly. When I pan the image upward, downward, to the right or to the left, it bounds the image to the original position.

I can, hardly to succeed, pan the image, when I pan it very very slowly.

May I ask for any measure that I can make to correct my situation?
I have set the "checkBounds" to "YES".

Thanks.

@loasjerry
Copy link
Author

This situation happens when the image's width or height is equal to cropSize's width or height.

Thanks

@natalia-osa
Copy link

I have the same issue, it almost makes this framework unusable..

@sethfri
Copy link

sethfri commented Jul 29, 2014

Upvote

@heitorfr
Copy link
Owner

If checkBounds is set to YES, the image has to fill the crop area completely for the crop to be accepted as valid. When you stop manipulating the image, if the crop isn't valid the image will jump back to a previous position where the image fills the crop area completely.
Can you confirm that is what you're experiencing? If that's not the behaviour you want, set checkBounds to NO.

@natalia-osa
Copy link

Well this is what we're experiencing. Problem is that is should act moreover like Apple preview - so if crop isn't valid it should not jump to previous position but it should calculate proper position nearest point, where user moved it. The way it is implemented atm it looks as 'not smooth'. Try for example to have an image 100x900 px. Now you have your crop area 100x100 pixels. You start in the middle. Moving crop box to begin at point (0,0) is nearly impossible because all the time it jumps back. Instead, it should move to closest possible position to where user moved crop area. I know it's a demanding and not so easy fix/feature, however it would make the library fully functional (at least in my eyes and as I suppouse @sethfri and @loasjerry ).

@sethfri
Copy link

sethfri commented Jul 31, 2014

@natalia-osa Maybe if you made a demo video, @heitorfr could better understand what you're describing?

@betzerra
Copy link

+1

@sethfri @heitorfr here's a video https://cloudup.com/c2ffTF5UPxO image is zoomed out and I'm trying to move it at its top (and then at its bottom)

/cc @natalia-osa @loasjerry

@felixdkatt
Copy link

Any word on this we are seeing similar issues. I have an image that is width of the crop view and height is larger. so trying to drag it down and accidentally ever slightly going left or right resets the pan. I have to slightly pan it a little a time and trying hard not to go left or right. I would expect it lock pan results for left right but allow the pan for up down. Best would be you have an image 200 x 200 and centered in a 100x100 crop frame that if you pulled hard down right it would snap back to top left corner of the crop frame and not go back to where it started to pan.

@mslathrop
Copy link

@sparq fixed the reset pan issue in this commit: wonderkiln@004ece5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants