Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Toggle minimum diagnostic severity for diagnostic picker #11245

Open
nick42d opened this issue Jul 19, 2024 · 4 comments
Open
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@nick42d
Copy link

nick42d commented Jul 19, 2024

When working on a branch with a large number of diagnostic warnings, errors can get drowned out. It would be nice to have a way of toggling this.

languages.toml diagnostic-severity is not suitable, as once I have tackled the errors I would like to toggle and move onto the warnings without editing configuration.

@nick42d nick42d added the C-enhancement Category: Improvements label Jul 19, 2024
@pascalkuthe
Copy link
Member

This would be solved by implementing fzf ORs operator. The last bit of fzf syntax we don't support yet. I have also found myself missing these for other applications. Then you could do $severity err|warn|info for example. I don't think adding a config option is something we would that. We are generally extremely conservative ablut adding config options.

@RoloEdits
Copy link
Contributor

For now, you should be able to enter %sev ERROR to filter that column. But this picker doesnt keep a history of what you entered so you would have to type it each time as you go through them.

@pascalkuthe
Copy link
Member

that is the same thing I was saying but only works for error but not for warnings for example (issue is about minimum severisyt not about just showing a single severity). I don't think manually typing a couple of characters into the picker is something that needs a config option

@nick42d
Copy link
Author

nick42d commented Jul 20, 2024

Cheers both! Learned some things from this;

From my perspective this covers my use case for now. I would generally just want to see errors only or all diagnostics. I will see if I can contribute to the docs PR at all.

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

4 participants