Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the LSP spinner... more spinny. #8704

Open
dpc opened this issue Nov 2, 2023 · 1 comment
Open

Make the LSP spinner... more spinny. #8704

dpc opened this issue Nov 2, 2023 · 1 comment
Labels
A-gui Area: Helix gui improvements C-enhancement Category: Improvements

Comments

@dpc
Copy link
Contributor

dpc commented Nov 2, 2023

I'm working on a fairly large Rust project and using rust-analyzer functionality in Helix a lot. Some actions take a while to kick in after called. Good example is "jump to workspace symbol". It's expected that it will be slow.

Helix has this "LSP working" indicator:

image

but it doesn't really spin much/at all when I'm waiting for the workspace symbol picker to show up, giving no indication if the editor registered the action.

There is already an issue to make the picker show immediately, which would be an improvement, but my enhancement request is more general one: for any actions this indicator should spin smoothly and continuously, instead of the current laggy/jerky/slow behavior. I'm guessing right now the update might be triggered by some requests/responses from the LSP itself, which kind of works but not all that well. Seems like enabling some timers that would trigger an update every 100ms or so if there are any outstanding LSP requests, would be better.

@dpc dpc added the C-enhancement Category: Improvements label Nov 2, 2023
@kirawi
Copy link
Member

kirawi commented Nov 2, 2023

#6446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-gui Area: Helix gui improvements C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants