Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--paragraph-fix should be default #109

Open
jashsayani opened this issue Sep 6, 2020 · 3 comments
Open

--paragraph-fix should be default #109

jashsayani opened this issue Sep 6, 2020 · 3 comments

Comments

@jashsayani
Copy link
Contributor

I dont see why running the migrator should have --paragraph-fix as an option. It should just fix it by default.

@curbengh
Copy link
Contributor

curbengh commented Sep 6, 2020

The paragraph fix is achieved by using a potentially unsafe workaround. The workaround may conflict with newer articles written using the new guternberg editor, which doesn't have the paragraph issue.

@jashsayani
Copy link
Contributor Author

What about blogs that have been around for a decade (over tens of wordpress versions) having some older posts written with the older editor and newer posts written with guternberg editor. Will the newer posts break?

Should be a way to safely do this. Some details on the "unsafe" nature would be great. Potential things to watch out for if newer posts are broken with the flag?

Also a disclaimer in the README where the flag is documented.

@adnan360
Copy link

It should just fix it by default.

This would be amazing if could be done. It would be one less option to worry about. Plus, if it becomes automatic, we can migrate wp sites that have both classic editor and Gutenberg posts.

I noticed that Gutenberg posts have <!-- wp:paragraph -->, <!-- wp:more -->, <!-- wp:image {"sizeSlug":"large"} --> etc. in the post content, but classic editor posts don't. If we check if any <!-- wp:* --> string doesn't exist and automatically apply paragraph fix then maybe this can work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants