Skip to content
This repository has been archived by the owner on Feb 8, 2021. It is now read-only.

swift5 #350

Closed
frozen5555 opened this issue Mar 28, 2019 · 8 comments
Closed

swift5 #350

frozen5555 opened this issue Mar 28, 2019 · 8 comments

Comments

@frozen5555
Copy link

I love gloss very much, so please update it to swift5, thanks!

@hkellaway hkellaway added this to the 3.0.0 milestone Mar 28, 2019
@hkellaway
Copy link
Owner

thank you! Gloss will definitely be updated to Swift 5 in due time

anyone who wants to get a headstart on this issue, i've created a branch called swift5. it has yet to be updated to be compatible as of this comment - but updates to achieve compatibility should be made against that branch

@frozen5555
Copy link
Author

thank you! Gloss will definitely be updated to Swift 5 in due time

anyone who wants to get a headstart on this issue, i've created a branch called swift5. it has yet to be updated to be compatible as of this comment - but updates to achieve compatibility should be made against that branch

ok,thanks!

@SpGibby
Copy link

SpGibby commented Mar 28, 2019

I need the WatchOS target moved up to at least Swift 4, too. Is that a thing you can do? I just tried by cloning the repo, creating a branch called swift5_watchOS, but can't write to the repo, so got rejected. I wanted to push that new branch and Pull Request that one into your current swift5 branch.

@hkellaway
Copy link
Owner

@VivintMan you are correct - oversight on my part; i'm going to update develop with Swift 4 for the watchOS target; will track that in a separate issue
#351

@SpGibby
Copy link

SpGibby commented Mar 28, 2019

Excellent, thanks! As the changes are going to be PR'd into develop, how long until that usually shows up in Master as a release? For Carthage, I can point to develop until then.

@hkellaway
Copy link
Owner

the project has been updated to Swift 5 - found on the swift5 branch currently

@yusuftor
Copy link

Can we merge this yet?

@hkellaway
Copy link
Owner

thanks for the poke! slipped my mind

Gloss 3.0.0 has been release 🎉 Swift 5 compatibility

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants