Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Runtime Keys by WinterCG #844

Closed
yusukebe opened this issue Jan 27, 2023 · 4 comments
Closed

Use Runtime Keys by WinterCG #844

yusukebe opened this issue Jan 27, 2023 · 4 comments

Comments

@yusukebe
Copy link
Member

yusukebe commented Jan 27, 2023

c.runtime returns which runtime is currently running on. The current keys are below:

type Runtime = 'node' | 'deno' | 'bun' | 'cloudflare' | 'fastly' | 'vercel' | 'lagon' | 'other'

Recently the WinterCG is defining the "Runtime Keys". We can see the draft in the below link:

According to this document, there are other names for the keys than the ones we have defined. For example, we defined the Cloudflare Workers as cloudflare, but WinterCG named it workerd.

Since Hono should be WinterCG compliant, we should use these keys (workerd etc.). The only thing is that Fastly has not joined WinterCG, so that should stay as it is.

This change will be a Breaking Change, so let's add it to the next branch.

@yusukebe
Copy link
Member Author

Hi @yujong-lee !

Are you interested in this matter? I would like to hear your opinion.

@yujonglee
Copy link
Contributor

@yusukebe
Yes, I think we should use the same key as WinterCG. Free from naming things!

It seems like a change as below will be enough. What do you think?

type Runtime = 'node' | 'deno' | 'bun' | 'workerd' | 'fastly' | 'edge-light' | 'lagon' | 'other'

@yusukebe
Copy link
Member Author

It seems like a change as below will be enough. What do you think?

Looks good! Could you create the PR? If you do so, make the PR into the next branch.

@yusukebe
Copy link
Member Author

This is fixed by #850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants