Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on envelop_hilbert algorithm in BioSigKit #12

Open
longluu opened this issue Apr 19, 2023 · 0 comments
Open

Question on envelop_hilbert algorithm in BioSigKit #12

longluu opened this issue Apr 19, 2023 · 0 comments

Comments

@longluu
Copy link

longluu commented Apr 19, 2023

Hi Hooman,

Thanks for making the BioSigKit open for the scientific community. I have a few questions about the function 'envelop_hilbert.m'.

  • On line 113: you have this:
    if ~isempty(nois_buf)
    Because you initialized nois_buf with a zero array so I think it should be always true. So I wonder if you actually mean to check if there is non-zero values in the nois_buf? If it's the case, I guess we have to use a different condition checking.

  • Line 88-93:

if threshold_style
   THR_SIG = 4*mean(env);
end

nois = mean(env)*(1/3);                                 % noise level
threshold = mean(env);                                  % signal level

Here you set initial values for threshold, noise and signal level based on the mean of Hilbert envelope. As I understand, the envelope mean is 0 (from line 77 env = env(:) - mean(env); ) so all of those values will be 0. I just want to confirm with you if that is the case.

  • Finally, just a general question. Do you have a reference for this algorithm somewhere so I can read in more detail the theory behind this?

Thanks again for you contribution. I'm looking forward to hearing from you.

Best,

Long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant