websocket proxy,what if the sever reject the connect with status other than 101

[kd128]

it happen when sever dothing like

var http = require('http');
var server = http.createServer(function (req, res) {
......//do normal request
}).listen(1337);


var accept  = function(request){
  if(ok){
    return true;
  } else {
    return false;
  }
}

server.on('upgrade',function (request, socket, head) {
      if(!accept(request)){//here the http-proxy will not work!
        socket.write("HTTP/1.1 406 Not Acceptable\r\n");
        socket.write("Connection: close\r\n");
        socket.write("\r\n");
        socket.end();
        return;
      }
       ......//do websocket request
 });

[kd128]

becasue socket.write("HTTP/1.1 406 Not Acceptable\r\n"),the http proxy will just emit an response event other than upgrade event!
please fix this bug!

[kd128]

please fix this bug as soon as possible,because it will make socket leave!

[jcrugzz]

@kd128 Can you see if running a socket.destroy() rather than a socket.end() behaves differently? But it is possible this is a bug. If you can add a fully working, minimal test case, this would expedite the process :). And ideally in the form of a pull request ;)

[minrk]

I've added a complete test case for this bug here. Switching between socket.end and destroy does not have any effect. Proxied websocket connections that are rejected are left open. This is particularly problematic in browsers (other than Safari for some reason) because a websocket stuck in the connecting state actually blocks other attempts to connect to the same server, even from other tabs.