Refactor filtering rules

[scripthunter7]

Since I took over the maintenance of the filter list, I've made many optimizations on it, but I think that there are still many filtering rules that should be improved. This issue focuses on solving this problem.

Goals:

• Remove rules for dead websites
• Remove outdated rules (if the website is still alive, but the filtering rule no longer works on it)
• Wherever possible, the *= and ^= attribute selectors should be reduced/replaced by a more optimal solution
  • Current stat:
    • ~490 search results for *=
    • ~90 search results for ^=
    • ~160 search results for *="banner"
    • ~50 search results for *="hirdetes"

In my opinion, the ideal scenario in the first round is to do a refactoring on each main website first, which consists of the following steps:

1. Visit the website with hufilter turned off in your adblocker
2. Collecting the actual filtering rules required for the website as user rules. If the website redirects to a dead or different domain, the rules should be deleted or the domain should be updated
3. Open a PR for that website with branch name fix/246/xy.hu where 246 refers to this issue and xy.hu to the corresponding website's address. Such a PR will probably affect several section files at the same time, but this is not a problem

Some general principles:

• The CSS selectors should be as "optimal" as possible, e.g. if it's possible to specify #id selector, avoid the [id="id"] attribute selector, try to avoid nth-child, etc.
• We prefer single selectors, so instead of ##.selector1, .selector2 please always use ##.selector1 and ##.selector2
• The rule should be prepared in such a way that if the structure of the website changes in the future, it will cause breakage on the page with the smallest possible chance
• Use Extended CSS only in justified cases

Any help is greatly appreciated! I think even some PR can be a big help if someone has the free time to do it. It's enough to take small steps, we don't have to do it all at once. 🙂

[scripthunter7]

@ehrhardt06 I see you've submitted some pretty good PRs so far, thank you :) Are you interested in this? Basically, the goal is to refactor the current rules. I think there may be several old or outdated rules in our filter.

I also plan to open some PRs following this scenario as my free time allows.

Note: I prefer English communication where possible, as other filter maintainers probably don't understand Hungarian :)

[ehrhardt06]

@scripthunter7 Sure, I'm happy to help. I'm quite a beginner in coding (it's far from being what I do, it's just a hobby for me) and I'm going to be quite busy in the coming weeks. So I will be slow, but I will try to open some new PRs over time.

I prefer English communication where possible, as other filter maintainers probably don't understand Hungarian :)

gotcha :)

[scripthunter7]

Thank you! 🙂 Please keep in mind that this is an epic issue, you don't have to solve everything, it's a long process. If you can help with just a few PRs by solving tasks that are close to you, it's already a huge help :) If you need help with anything, feel free to tag me in your PRs / comments.

[scripthunter7]

@ehrhardt06 I think at this point we should focus on dead websites, especially those with a non-hu TLD

[ehrhardt06]

@scripthunter7 sure thing