Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some -abp-has rules to AdGuard iOS #453

Open
scripthunter7 opened this issue Mar 25, 2024 · 3 comments
Open

Port some -abp-has rules to AdGuard iOS #453

scripthunter7 opened this issue Mar 25, 2024 · 3 comments

Comments

@scripthunter7
Copy link
Member

Basic AdGuard iOS content blocker doesn't support Extended CSS, but probably several -abp-has based rules can be ported to native has to be compatible with the basic iOS cb.

@Cyberbeni
Copy link
Contributor

I was thinking about having an intermediary build step that creates iOS compatible rules from all the rules that include -abp-has via a regex. Then runs aglint on them and deletes the lines that produce an error.

Or if all rules created like that are valid on iOS then there is no need for linting to filter out the bad ones.

@scripthunter7
Copy link
Member Author

I was thinking about having an intermediary build step that creates iOS compatible rules from all the rules that include -abp-has via a regex.

Yes, something similar would probably work in most cases, although I'm not sure if there is/or will be a rule where this would cause problems (eg if the two rules only work together, but separately cause some kind of incorrect blocking - e.g. one rule only uses -abp-has, but the other -abp-contains, which is not supported by native CSS at all)

@Cyberbeni
Copy link
Contributor

There are rules which contain both (for example this), so there is certainly a need to lint the autogenerated rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants