Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: use JSX transform feature #760

Open
GerardasB opened this issue Mar 8, 2024 · 1 comment
Open

Maintenance: use JSX transform feature #760

GerardasB opened this issue Mar 8, 2024 · 1 comment
Labels
good first issue Good for newcomers internal No change in this PR have impact on the public package features.

Comments

@GerardasB
Copy link
Collaborator

GerardasB commented Mar 8, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Enable JSX transform feature.
Remove explicit React module imports, only import specific hooks where needed.
https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html

Related change in presentation package: https://github.com/iTwin/presentation/blob/1794a831296bd88e73a4c8b6a6bd1cb69e275605/packages/components/tsconfig.json#L4
@GerardasB GerardasB added good first issue Good for newcomers internal No change in this PR have impact on the public package features. labels Mar 8, 2024
@mayank99
Copy link

mayank99 commented Jul 8, 2024 •
edited
Loading

We tried using the new transform in iTwinUI but had to revert it because it is not correctly supported in React 17 + Webpack 5. More details in iTwin/iTwinUI#2122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers internal No change in this PR have impact on the public package features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mayank99 @GerardasB @ignas-k