Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to Vitest #1226

Closed
arturmuller opened this issue Mar 11, 2024 · 0 comments · Fixed by #1242
Closed

Move tests to Vitest #1226

arturmuller opened this issue Mar 11, 2024 · 0 comments · Fixed by #1242
Labels
♥ help please Issues that we'd love help solving

Comments

@arturmuller
Copy link
Collaborator

Superstruct tests are currently written in Mocha, which is starting to show its age. It would be great if we could move to something like Vitest. This has two goals:

  1. Unblock NodeNext Compat #1224 (Mocha is currently failing because it is not compatible with the new config)
  2. Make the lib more comfortable to contribute/work with for new contributors — I doubt there are many people who would choose Mocha over Vitest in 2024.

@ciscoheat — I saw that you already got started on this in #1211 , but when I try to run it locally it didn't actually run most of the tests. If you were willing to look into this again, with the sole focus being moving to Vitest, it would be massively appreciated. 🙌

So that goal is:

  1. Making sure that all tests run
  2. (stretch goal) Refactoring the tests so that they seem familiar to a person who has only ever worked with Vitest. (The current implementation is not how I would expect anyone to write Vitest tests).
@arturmuller arturmuller added the ♥ help please Issues that we'd love help solving label Mar 11, 2024
@arturmuller arturmuller pinned this issue Mar 11, 2024
@arturmuller arturmuller changed the title Move to tests to Vitest Move tests to Vitest Mar 11, 2024
@arturmuller arturmuller unpinned this issue Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♥ help please Issues that we'd love help solving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant