Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release new version early to hotfix performance issue <3 #1100

Closed
kamronbatman opened this issue May 10, 2018 · 5 comments
Closed

Please release new version early to hotfix performance issue <3 #1100

kamronbatman opened this issue May 10, 2018 · 5 comments

Comments

@kamronbatman
Copy link

kamronbatman commented May 10, 2018

@benmosher, I would very much love it if you could release the next version early, or a hotfix that has the performance fix. It would definitely save my sanity. Thank you!

EDIT: I think it will require a new version of eslint-import-resolver-node and eslint-import-resolver-webpack to be published too?

@kamronbatman kamronbatman changed the title Please release new version early to hotfix performance <3 Please release new version early to hotfix performance issue <3 May 10, 2018
@benmosher benmosher mentioned this issue May 17, 2018
2 tasks
@benmosher
Copy link
Member

👍🏻

@benmosher
Copy link
Member

btw I didn't see any node resolver changes in the intervening commits, do you have something in mind that needs to published for that?

@kamronbatman
Copy link
Author

@benmosher, it was specifically this change: f0d0c4f
Which looks like it touches the node and webpack resolvers.
This was supposed to fix the ~90sec lint times.

Let me know if I am misunderstanding. Thanks!

@ljharb
Copy link
Member

ljharb commented May 17, 2018

The only change to the node resolver is for tests; it doesn’t impact it at runtime.

@kamronbatman
Copy link
Author

I thought PR #1091 fixed Issue #788.
Indeed, I just tested and I am still having an issue. Now I am not sure if it is related or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants