Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code space to Tx sync and async Response #1382

Closed
ljoss17 opened this issue Dec 7, 2023 · 0 comments · Fixed by #1383
Closed

Add code space to Tx sync and async Response #1382

ljoss17 opened this issue Dec 7, 2023 · 0 comments · Fixed by #1383
Labels
enhancement New feature or request

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Dec 7, 2023

Description

Sync and async transaction broadcast request errors have a code to identify the cause of the error, but these errors can originated from different sources such as Cosmos SDK, https://github.com/cosmos/cosmos-sdk/blob/main/types/errors/errors.go, or ibc-go channel module, https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/types/errors.go.
The code alone might not have enough information as the sources sometimes use the same codes. For example insufficient fee from Cosmos SDK and invalid packet from ibc-go channel module both have the error code 13:

Definition of "done"

Adding the codespace to the Response would fix this issue.

@ljoss17 ljoss17 added the enhancement New feature or request label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant