Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to override User-Agent for queries #1425

Closed
freak12techno opened this issue May 22, 2024 · 3 comments · Fixed by #1429
Closed

Add the possibility to override User-Agent for queries #1425

freak12techno opened this issue May 22, 2024 · 3 comments · Fixed by #1429
Labels
enhancement New feature or request

Comments

@freak12techno
Copy link
Contributor

Description

Required for informalsystems/hermes#3979.

TLDR: there should be a way for the library users', including Hermes, to override the User-Agent header for all the queries such an app does, so it would be easier for the node owners to understand which app is doing which queries, given that the app overrides User-Agent using this feature.

Definition of "done"

A library provides a way to specify a custom User-Agent when creating a HttpClient.

@freak12techno
Copy link
Contributor Author

@romac can we bump tendermint-rs to be able to use the new version in hermes?

@romac
Copy link
Member

romac commented May 29, 2024

I will release this by end of week and then we can bump tendermint-rs in Hermes and set an appropriate user agent.

@freak12techno
Copy link
Contributor Author

@romac lovely. Can you ping me once it's done?
Also, feel free to assign me to informalsystems/hermes#3979, I basically have already done it, except for a new things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants