Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: hide-suggestions-shelf does not work in tablet #1398

Closed
girshcatt opened this issue Sep 20, 2023 · 1 comment
Closed

bug: hide-suggestions-shelf does not work in tablet #1398

girshcatt opened this issue Sep 20, 2023 · 1 comment
Labels
Bug report Something isn't working

Comments

@girshcatt
Copy link 

          This is a limitation of the current patch method

To solve this issue we need a more ideal way to hook the navbar index

Originally posted by @inotia00 in #1327 (comment)

After you changed hide suggestions patch it stopped to work right on tablets, now it create blank space instead of suggestion shelves like on this screen recording

Screen_Recording_20230920_233434_ReVanced.Extended.mp4
@inotia00 inotia00 added the Bug report Something isn't working label Sep 20, 2023
@inotia00 inotia00 changed the title Tablet bug with hide-suggestions-shelf, yes another one( bug: hide-suggestions-shelfdoes not work in tablet Sep 20, 2023
@girshcatt girshcatt changed the title bug: hide-suggestions-shelfdoes not work in tablet bug: hide-suggestions-shelf does not work in tablet Sep 21, 2023
@inotia00
Copy link
Owner

fixed in revanced-patches-v2.190.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inotia00 @girshcatt