Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

font-awesome doesn't work #140

Open
leinue opened this issue Mar 31, 2019 · 2 comments
Open

font-awesome doesn't work #140

leinue opened this issue Mar 31, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@leinue
Copy link

leinue commented Mar 31, 2019

image

@james-martin-jd
Copy link
Contributor

Hey leinue, thanks for the report!

Font Awesome actually is working, it just requires a few extra steps in the current version of the SDK, and these steps are currently undocumented. Right now we're using the react-fontawesome library, so some icons (even newly added ones in the style guide) may not render if you don't add them manually.

The link above has a good guide for how to include them, but I'm going to leave this ticket open and marked as enhancement until we can either document the process or remove this extra library dependency.

Thanks again!

@james-martin-jd
Copy link
Contributor

I'm also going to move this issue to the generator repo.

@james-martin-jd james-martin-jd transferred this issue from inrupt/solid-react-sdk Apr 4, 2019
@james-martin-jd james-martin-jd self-assigned this Apr 4, 2019
@james-martin-jd james-martin-jd added the enhancement New feature or request label Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants